Messages in this thread | | | Date | Sun, 12 Mar 2006 18:23:32 +0100 | From | Kay Sievers <> | Subject | Re: [PATCH] [PNP] 'modalias' sysfs export |
| |
On Sun, Mar 12, 2006 at 12:17:19PM +0100, Pierre Ossman wrote: > Andrew Morton wrote: > > I assume you mean that the drivers/pnp/card.c patch of > > pnp-modalias-sysfs-export.patch needs to be removed and this patch applies > > on top of the result. > > > > But I don't want to break udev. > > > > I suppose I wasn't entirely clear there. I'd like you to do the first > part (remove the card.c part), but not apply this second patch. I just > sent that in as a means of getting the ball rolling again.
Again, multiline sysfs modalias files are not going to happen. Find a sane way to encode the list of devices into a single string, or don't do it at all. And it must be available in the event environment too.
> The reason I'm pushing this issue is that Red Hat decided to drop all > magical scripts that figured out what modules to load and instead only > use the modalias attribute. They consider the right way to go is to get > the PNP layer to export modalias, so that's what I'm trying to do.
There is no need to rush out with this half-baken solution. This simple udev rule does the job for you, if you want pnp module autoloading with the current kernel: SUBSYSTEM=="pnp", RUN+="/bin/sh -c 'while read id; do /sbin/modprobe pnp:d$$id; done < /sys$devpath/id'"
Andrew, please make sure, that this patch does not hit mainline until there is a _sane_ solution to the multiple id's exported for a single device problem.
Thanks, Kay - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |