Messages in this thread | | | Subject | Re: [PATCH] EDAC: core EDAC support code | From | Arjan van de Ven <> | Date | Sat, 11 Mar 2006 08:18:31 +0100 |
| |
On Fri, 2006-03-10 at 17:57 -0800, Dave Peterson wrote: > On Friday 10 March 2006 13:23, Arjan van de Ven wrote: > > hmm ok so I want a function that takes a device as parameter, and checks > > the state of that device for errors. Internally that probably has to go > > via a function pointer somewhere to a device specific check method. > > > > Or maybe a per test-type (pci parity / ECC / etc) check > > > > int pci_check_parity_errors(struct pci_dev *dev, int flags); > > > > something like that, or pci_check_and_clear_parity_errors() > > (although that gets too long :) > > > > drivers can call that, say, after firmware init or something to validate > > their device is sanely connected. Maybe pci_enable_device() could call > > it too. > > > > This also needs a pci_suspend_parity_check() ... _resume_ ... so that > > the driver can temporarily disable any checks, for example during device > > reset/init. And then just before resume, it manually clears a check. > > ok, perhaps things might look something like this?
<snip>
sounds like overdesign to me ;)
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |