Messages in this thread | | | Date | Fri, 10 Mar 2006 11:57:09 +0300 | From | Kirill Korotaev <> | Subject | Re: [PATCH] ext3: ext3_symlink should use GFP_NOFS allocations inside (ver. 3) |
| |
>>Andrew, >> >>Fixed both comments from Al Viro (thanks, Al): >>- should have a separate helper >>- should pass 0 instead of GFP_KERNEL in page_symlink() > > >> >>+ page = find_or_create_page(mapping, 0, >>+ mapping_gfp_mask(mapping) | gfp_mask); > > > > > this does not work; GFP_NOFS has a bit *LESS* than GFP_KERNEL, not a bit > more. As such a | operation isn't going to be useful.... > > (So I think that while Al's intention was good, the implication of it > isn't ;) Oh no... Had to sleep well today... :/ Al, are you agree with the original patch then? I don't think it is a good idea to introduce AND mask instead :)
Thanks, Kirill
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |