lkml.org 
[lkml]   [2006]   [Mar]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [2.6 patch] drivers/block/paride/pd.c: fix an off-by-one
On Sat, 11 Mar 2006 04:42:53 +0100 Adrian Bunk wrote:

> The Coverity checker found this off-by-one error.
>
>
> Signed-off-by: Adrian Bunk <bunk@stusta.de>
>
> --- linux-2.6.16-rc5-mm3-full/drivers/block/paride/pd.c.old 2006-03-11 02:07:21.000000000 +0100
> +++ linux-2.6.16-rc5-mm3-full/drivers/block/paride/pd.c 2006-03-11 02:07:50.000000000 +0100
> @@ -275,7 +275,7 @@
> int i;
>
> printk("%s: %s: status = 0x%x =", disk->name, msg, status);
> - for (i = 0; i < 18; i++)
> + for (i = 0; i < 17; i++)
> if (status & (1 << i))
> printk(" %s", pd_errs[i]);
> printk("\n");

Please use ARRAY_SIZE(pd_errs)
and #include <linux/kernel.h>

---
~Randy
Please use an email client that implements proper (compliant) threading.
(You know who you are.)
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-03-11 05:04    [W:0.023 / U:0.280 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site