Messages in this thread | | | Date | 1 Mar 2006 13:54:05 +0100 | Date | Wed, 1 Mar 2006 13:54:05 +0100 | From | Andi Kleen <> | Subject | Re: [patch 2/5] Remove unnecessary lapic definition from acpidef.h |
| |
On Tue, Feb 28, 2006 at 04:15:59PM -0800, Ashok Raj wrote: > Dont know why this exists... just happened to trip me when i used a > variable name with lapic, and until i looked at the pre-processed > output couldnt figure out we had a lame definition like this. > > Hope iam not breaking anything here..
No, the file is a mess anyways.
> > Signed-off-by: Ashok Raj <ashok.raj@intel.com> > ------------------------------------------------ > include/asm-i386/apicdef.h | 1 - > include/asm-x86_64/apicdef.h | 2 -- > 2 files changed, 3 deletions(-) > > Index: linux-2.6.16-rc1-mm4/include/asm-i386/apicdef.h > =================================================================== > --- linux-2.6.16-rc1-mm4.orig/include/asm-i386/apicdef.h > +++ linux-2.6.16-rc1-mm4/include/asm-i386/apicdef.h > @@ -120,7 +120,6 @@ > */ > #define u32 unsigned int
Like this should go too.
> > -#define lapic ((volatile struct local_apic *)APIC_BASE)
I'll take a stab at cleaning it up.
Thanks, -Andi - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |