Messages in this thread | | | Date | Wed, 1 Mar 2006 09:10:35 +0000 | From | Ben Dooks <> | Subject | Re: [patch] s3c2412 support |
| |
On Tue, Feb 28, 2006 at 03:18:00PM +0100, Koen Martens wrote: > From: Koen Martens <kmartens@sonologic.nl> > > Changes are: > - Added s3c2412-specific files to arch/arm/mach-s3c2410 > - Added s3c2412 detection to arch/arm/mach-s3c2410/cpu.c > - Added CONFIG_CPU_S3C2412 > - Added s3c2412 specific registers and register addresses to > various regs-*.h files in include/asm-arm/arch-s3c2410
It would help to split these emails into smaller chunks than all the files so that comments could be with the chunks that it goes with.
Kconfig.diff - fine, no problems here Makefile.diff - going to have to remove those #s at somepoint regs-clock.diff - didn't need to add s3c2412_get_pll, same as s3c2410_get_pll regs-gpio.diff - group the s3c2412 changes together into larger #ifdefs regs-irq.diff - looks fine regs-rtc.diff - two sets of changes here? 2410 and 2412 additions s3c2412_c.diff - looks fine s3c2412_h.diff - looks fine
cpu.diff:
the 2412 is an ARM926EJS, so I'd expect the core-ID accessed via the co-processor registers to be diffeernt, so this could give the indication of what sort of CPU to try.
this also seems to have the S3C2442 ID patch from the patch-q in it, please be careful about merging patches like that.
> All changes are preliminary, final documentation is not yet available > from samsung. We did test on actual hardware, but outside the linux > kernel (due to limited number of actual chips we have available and > lack of proper PCB with serial lines exported).
[snip]
-- Ben
Q: What's a light-year? A: One-third less calories than a regular year.
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |