Messages in this thread | | | Date | Wed, 1 Mar 2006 15:37:14 -0800 | From | Andrew Morton <> | Subject | Re: [git patches] ocfs2 updates |
| |
Mark Fasheh <mark.fasheh@oracle.com> wrote: > > + "Extent %d at e_blkno %"MLFu64" of inode %"MLFu64" goes past ip_clusters of %u\n",
Sometime, please consider killing MLFu64 and friends.
#if (BITS_PER_LONG == 32) || defined(CONFIG_X86_64) || (defined(CONFIG_UML_X86) && defined(CONFIG_64BIT)) #define MLFi64 "lld" #define MLFu64 "llu" #define MLFx64 "llx" #else #define MLFi64 "ld" #define MLFu64 "lu" #define MLFx64 "lx" #endif
You covered most cases there, but sh64 implements u64 as `unsigned long long' (for example).
Generally we solve this problem by just using %ll and casting the args appropriately. That does have some runtime cost on 32-bit.
u64 and s64 are the easy case - it gets stickier on things like sector_t whose size is controlled by a CONFIG_thing on 32-bit.
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |