Messages in this thread Patch in this message | | | Subject | [PATCH] proc: Reference couting fix. | From | (Eric W. Biederman) | Date | Wed, 01 Mar 2006 00:20:34 -0700 |
| |
Fix reference counts in seccomp_write, and mem_read.
While looking for the bug I found two other places I goofed.
Signed-off-by: Eric W. Biederman <ebiederm@xmission.com>
---
fs/proc/base.c | 9 ++++++++- 1 files changed, 8 insertions(+), 1 deletions(-)
0774b9b05aa41a25d72f31498fc2967bfe8e60b7 diff --git a/fs/proc/base.c b/fs/proc/base.c index 8d73c6a..6a26847 100644 --- a/fs/proc/base.c +++ b/fs/proc/base.c @@ -671,6 +671,9 @@ static ssize_t mem_read(struct file * fi int ret = -ESRCH; struct mm_struct *mm; + if (!task) + goto out_no_task; + if (!MAY_PTRACE(task) || !ptrace_may_attach(task)) goto out; @@ -720,6 +723,8 @@ out_put: out_free: free_page((unsigned long) page); out: + put_task_struct(task); +out_no_task: return ret; } @@ -965,10 +970,12 @@ static ssize_t seccomp_write(struct file if (unlikely(tsk->seccomp.mode)) goto out; + result = -EFAULT; memset(__buf, 0, sizeof(__buf)); count = min(count, sizeof(__buf) - 1); if (copy_from_user(__buf, buf, count)) - return -EFAULT; + goto out; + seccomp_mode = simple_strtoul(__buf, &end, 0); if (*end == '\n') end++; -- 1.2.2.g709a-dirty - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |