Messages in this thread Patch in this message | | | From | "Chen, Kenneth W" <> | Subject | RE: [2.6 patch] let IA64_GENERIC select more stuff | Date | Wed, 8 Feb 2006 14:24:51 -0800 |
| |
Adrian Bunk wrote on Wednesday, February 08, 2006 1:38 PM > > Not really, it helps a bit by selecting some things we know we need > > for all GENERIC builds. True we can't make it bullet proof, but whats > > there is better than removing it. > > Like the bug of allowing the illegal configuration NUMA=y, FLATMEM=y?
You can't even compile a kernel with that combination ... Just about every arch except ia64 turns off ARCH_FLATMEM_ENABLE if NUMA=y. ia64 can just do the same thing. Instead of mucking around with select, fix the bug at its source. The real culprit is in mm/Kconfig, it shouldn't enable ARCH_FLATMEM_ENABLE if NUMA=y.
Fix ARCH_FLATMEM_ENABLE dependency in ia64 arch.
Signed-off-by: Ken Chen <kenneth.w.chen@intel.com>
--- ./arch/ia64/Kconfig.orig 2006-02-08 14:57:40.597354431 -0800 +++ ./arch/ia64/Kconfig 2006-02-08 15:04:15.552427718 -0800 @@ -298,7 +298,8 @@ config ARCH_DISCONTIGMEM_ENABLE See <file:Documentation/vm/numa> for more. config ARCH_FLATMEM_ENABLE - def_bool y + depends on !NUMA + def_bool y if !NUMA config ARCH_SPARSEMEM_ENABLE def_bool y
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |