Messages in this thread Patch in this message | | | Date | Wed, 8 Feb 2006 08:20:20 -0800 (PST) | From | Christoph Lameter <> | Subject | Re: [discuss] mmap, mbind and write to mmap'ed memory crashes 2.6.16-rc1[2] on 2 node X86_64 |
| |
On Wed, 8 Feb 2006, Andi Kleen wrote:
> > So a provisional solution would be to simply ignore empty zones in > > bind_zonelist? > > That would likely prevent the crash yes (Bharata can you test?) > > But of course it still has the problem of a lot of memory being unpolicied > on machines with >4GB if there's both DMA32 and NORMAL.
The fix could result in a zonelist with no zones. So we can answer one question in __alloc_pages().
Index: linux-2.6.16-rc2/mm/page_alloc.c =================================================================== --- linux-2.6.16-rc2.orig/mm/page_alloc.c 2006-02-08 00:05:09.000000000 -0800 +++ linux-2.6.16-rc2/mm/page_alloc.c 2006-02-08 08:18:59.000000000 -0800 @@ -913,7 +913,7 @@ restart: z = zonelist->zones; /* the list of zones suitable for gfp_mask */ if (unlikely(*z == NULL)) { - /* Should this ever happen?? */ + /* May occur if MPOL_BIND results in an empty zonelist */ return NULL; } - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |