Messages in this thread | | | Date | Tue, 7 Feb 2006 11:17:17 -0800 (PST) | From | Luben Tuikov <> | Subject | Re: [PATCH] x86-64: improve the format of stack dumps |
| |
--- Andi Kleen <ak@suse.de> wrote: > On Tuesday 07 February 2006 06:13, Luben Tuikov wrote: > > Improve the format of stack dumps for x86-64. > > * Single column of stack entries. (similar to other arches) > > I don't like that part as I wrote earlier.It's a waste of precious > screen space, no matter how often you retransmit the patch. The old > format had a chance to even fit on a 80x25 screen, with your new one > it is extremly unlikely. > > Overall you're making less information available in a common case > for cosmetics.
And as I wrote earlier, this patch doesn't only improve output, it also _reuses_ code, i.e. __print_symbol() which your code recreates in printk_address(). Now printk_address() reuses the common __print_symbol().
One very important thing this patch also does is that it prints the offsets in hexadecimal, as opposed to decimal. I.e. from
0xNNNNNNNN+DDD to 0xNNNNNNNNN+0xTTT/0xWWW
As to "less space", this patch prints _identical_ information as the code before it, as I'm sure you can see by reading the patch itself.
Thanks, Luben
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |