Messages in this thread | | | Date | Wed, 8 Feb 2006 00:23:55 +0530 | From | Dipankar Sarma <> | Subject | Re: [PATCH] percpu data: only iterate over possible CPUs |
| |
On Tue, Feb 07, 2006 at 10:43:55AM -0800, Linus Torvalds wrote: > > > On Wed, 8 Feb 2006, Dipankar Sarma wrote: > > > > One would think so, but I recall not all archs did that. Alpha for > > example sets up cpu_possible_map in smp_prepare_cpus(). It however > > makes more sense to fix the arch then use NR_CPUS, IMO. > > Ehh? alpha does it in setup_smp(), which in turn is called very early from > setup_arch(). > > Were you perhaps thinking of something else? Or am I just going blind and > confused?
I am looking at 2.6.16-rc1 and I don't see cpu_possible_map being set in setup_smp(). That said, it seems alpha setup_smp() probes for cpus there, so there is no reason why it cannot be set there. I think it is wrong not to set cpu_possible_map very early.
Or perhaps it got fixed later on, in which case, oh well, I need to download more often. <sigh>.
Thanks Dipankar - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |