lkml.org 
[lkml]   [2006]   [Feb]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [RFC][PATCH] unify pfn_to_page [25/25] sparc64 pfn_to_page/page_to_pfn
From
From: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Date: Mon, 06 Feb 2006 20:23:33 +0900

> --- cleanup_pfn_page.orig/arch/sparc64/mm/init.c
> +++ cleanup_pfn_page/arch/sparc64/mm/init.c
> @@ -320,16 +320,6 @@ void __kprobes flush_icache_range(unsign
> }
> }
>
> -unsigned long page_to_pfn(struct page *page)
> -{
> - return (unsigned long) ((page - mem_map) + pfn_base);
> -}
> -
> -struct page *pfn_to_page(unsigned long pfn)
> -{
> - return (mem_map + (pfn - pfn_base));
> -}
> -
> void show_mem(void)
> {
> printk("Mem-info:\n");

We did not want these inlined on sparc64 for a good reason.
The pointer arithmatic gets expanded to many additions,
subtractions, and shifts, and I felt it too much to inline.

If you want to consolidate all of the implementations, that's
fine, but please keep the option of not inlining these two
routines.

Thank you.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-02-06 22:27    [W:1.291 / U:0.048 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site