Messages in this thread | | | Subject | Re: [RFC][PATCH 3/5] Virtualization/containers: UTSNAME | From | (Eric W. Biederman) | Date | Mon, 06 Feb 2006 01:21:13 -0700 |
| |
I am disturbed by the introduction of #defines like current_vps() and vps_utsname.
Magic lower case #defines are usually a bad idea.
These defines hide the cost of the operations you are performing. At that point you might as well name the thing system_utsname so you don't have to change the code.
And of course you failed to change several references to system_utsname.
Eric - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |