lkml.org 
[lkml]   [2006]   [Feb]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH, RFC] Driver for reading HP laptop LCD brightness
From
Date
On Sun, 2006-02-05 at 13:55 +0000, Matthew Garrett wrote:
> + if (enable==0) {
> + return snprintf(buf, PAGE_SIZE, "NA\n");
> + }
> +
> + disable_irq(8);
> +
> + outb(0x97, 0x72);
> + value = inb(0x73);
> +
> + enable_irq(8);
> +

disable_irq() and enable_irq() are really really evil. Are you sure you
need these? To me on first sight it looks like a bug (think of shared
interrupts for example), can you explain what you are trying to achieve
with these?

Greetings,
Arjan van de Ven

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-02-05 15:29    [W:0.551 / U:0.592 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site