lkml.org 
[lkml]   [2006]   [Feb]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [RFC 3/4] firewire: unconditionally export hpsb_send_packet_and_wait
    Johannes Berg wrote:
    > mem1394 will need hpsb_send_packet_and_wait so it needs to be exported
    > unconditionally.
    >
    > diff --git a/drivers/ieee1394/ieee1394_core.c b/drivers/ieee1394/ieee1394_core.c
    > index 17afc3b..5800534 100644
    > --- a/drivers/ieee1394/ieee1394_core.c
    > +++ b/drivers/ieee1394/ieee1394_core.c
    > @@ -589,6 +589,7 @@ int hpsb_send_packet_and_wait(struct hps
    >
    > return retval;
    > }
    > +EXPORT_SYMBOL(hpsb_send_packet_and_wait);
    >
    > static void send_packet_nocare(struct hpsb_packet *packet)
    > {
    > @@ -1269,7 +1270,6 @@ EXPORT_SYMBOL(hpsb_packet_received);
    > EXPORT_SYMBOL_GPL(hpsb_disable_irm);
    > #ifdef CONFIG_IEEE1394_EXPORT_FULL_API
    > EXPORT_SYMBOL(hpsb_send_phy_config);
    > -EXPORT_SYMBOL(hpsb_send_packet_and_wait);
    > #endif
    >
    > /** ieee1394_transactions.c **/

    Leave the export down at the end of ieee1394_core.c among all other
    exports of ieee1394. Just move the export above the #ifdef.

    Same for the two new exports by "[RFC 2/4] firewire: dynamic cdev
    allocation below firewire major": Place them at the end of ieee1394_core.c.
    --
    Stefan Richter
    -=====-=-==- --=- --=-=
    http://arcgraph.de/sr/
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/
    \
     
     \ /
      Last update: 2006-02-05 14:48    [from the cache]
    ©2003-2011 Jasper Spaans