Messages in this thread | | | Subject | Re: [RFC][PATCH 1/5] Virtualization/containers: startup | From | Benjamin Herrenschmidt <> | Date | Mon, 06 Feb 2006 11:56:31 +1100 |
| |
On Fri, 2006-02-03 at 19:58 +0300, Kirill Korotaev wrote:
> +static inline vps_t get_vps(vps_t vps) > +{ > + atomic_inc(&vps->refcnt); > + return vps; > +} > + > +static inline void put_vps(vps_t vps) > +{ > + atomic_dec(&vps->refcnt); > +}
I'm not too sure about the refcounting here .. you never destroy the object ? Also, why introduce your own refcounting mecanism instead of using existing ones ? You could probably use at least a kref to get a nice refcount + destructor instead of home made atomics based. Maybe some higher level structure if you think it makes sense (not too sure what this virtualization stuff is about so I can't comment on what data structure is appropriate here).
Cheers, Ben.
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |