lkml.org 
[lkml]   [2006]   [Feb]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] Introduce __iowrite32_copy
    On vr, 2006-02-03 at 06:30 +0000, Al Viro wrote:
    > On Thu, Feb 02, 2006 at 03:57:20PM +0100, Heiko Carstens wrote:
    > > > lib/iomap_copy.c: In function '__iowrite32_copy':
    > > > lib/iomap_copy.c:40: error: implicit declaration of function '__raw_writel'
    > > >
    > > > We compile with -Werror-implicit-function-declaration, and s390 does not
    > > > have a __raw_writel.
    > > > Should it just define __raw_writel to writel, like uml does a few
    > > > commits later?
    > >
    > > I sent a patch which fixes this for s390 earlier today.
    > > http://lkml.org/lkml/2006/2/2/78
    >
    > Which leaves mips, m68k and sh64... For m68k cross-builds I've added
    > #define __raw_writel raw_outl in raw_io.h, but I'm not sure if m68k
    > folks are OK with that. Comments?

    That's exactly what I have done in my local tree for the 53c700 driver
    which uses the interfaces of lib/iomap.c, so it's fine with me.


    Kind regards,

    Kars.


    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2006-02-03 09:37    [W:0.031 / U:125.080 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site