[lkml]   [2006]   [Feb]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    Patch in this message
    SubjectRe: [PATCH] powerpc: restore eeh_add_device_late() prototype
    Sigh, I forgot to actually CC, and I also left off
    my signed-off-by line (added below). Sorry about that.

    On Tue, Feb 28, 2006 at 04:19:09PM -0800, Mark Fasheh wrote:
    A search on the linux-kernel, linuxppc-dev mailing lists and the git tree at
    git:// didn't show
    this issue fixed or reported. If I missed something please ignore :)

    I get a compile failure trying to build a powerpc kernel:

    arch/powerpc/platforms/pseries/eeh.c: In function `eeh_add_device_tree_late':
    arch/powerpc/platforms/pseries/eeh.c:901: warning: implicit declaration of function `eeh_add_device_late'
    arch/powerpc/platforms/pseries/eeh.c: At top level:
    arch/powerpc/platforms/pseries/eeh.c:918: error: conflicting types for 'eeh_add_device_late'
    arch/powerpc/platforms/pseries/eeh.c:901: error: previous implicit declaration of 'eeh_add_device_late' was here
    make[2]: *** [arch/powerpc/platforms/pseries/eeh.o] Error 1

    It seems commit 827c1a6c1a5dcb2902fecfb648f9af6a532934eb removed this
    prototype from eeh.h. The following patch restores it.

    Signed-off-by: Mark Fasheh <>

    diff --git a/include/asm-powerpc/eeh.h b/include/asm-powerpc/eeh.h
    index 7dfb408..4250fa1 100644
    --- a/include/asm-powerpc/eeh.h
    +++ b/include/asm-powerpc/eeh.h
    @@ -62,6 +62,7 @@ void __init pci_addr_cache_build(void);
    void eeh_add_device_early(struct device_node *);
    void eeh_add_device_tree_early(struct device_node *);
    +void eeh_add_device_late(struct pci_dev *);
    void eeh_add_device_tree_late(struct pci_bus *);

    @@ -117,6 +118,8 @@ static inline void pci_addr_cache_build(

    static inline void eeh_add_device_early(struct device_node *dn) { }

    +static inline void eeh_add_device_late(struct pci_dev *dev) { }
    static inline void eeh_remove_device(struct pci_dev *dev) { }

    static inline void eeh_add_device_tree_early(struct device_node *dn) { }
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to
    More majordomo info at
    Please read the FAQ at
     \ /
      Last update: 2006-03-01 02:06    [W:0.023 / U:103.232 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site