lkml.org 
[lkml]   [2006]   [Feb]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] kprobes: kprobe_mutex is no longer a semaphore
    On 2/27/06, Prasanna S Panchamukhi <prasanna@in.ibm.com> wrote:
    > On Sat, Feb 25, 2006 at 12:42:46PM +0100, Jesper Juhl wrote:
    > >
    > > kprobe_mutex used to be a semaphore it is now a mutex, so calling down/up on
    > > it is wrong, we should be using mutex_lock/mutex_unlock instead.
    > >
    > > gcc was kind enough to warn about this :
    > > arch/i386/kernel/kprobes.c: In function `arch_remove_kprobe':
    > > arch/i386/kernel/kprobes.c:135: warning: passing arg 1 of `down' from incompatible pointer type
    > > arch/i386/kernel/kprobes.c:137: warning: passing arg 1 of `up' from incompatible pointer type
    > >
    > >
    > > Signed-off-by: Jesper Juhl <jesper.juhl@gmail.com>
    >
    >
    > Looks good, this patch depends on the sem2mutex-kprobes.patch in -mm
    > tree.
    > http://www.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.16-rc4/2.6.16-rc4-mm2/broken-out/sem2mutex-kprobes.patch
    >
    > Acked-by : Prasanna S Panchamukhi <prasanna@in.ibm.com>
    >

    Thank you.

    Are you going to merge it / push it to Andrew or Linus?
    If not I'll just queue it up with some other patches I have lying
    around and forward it with those other patches in a week or so.


    --
    Jesper Juhl <jesper.juhl@gmail.com>
    Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html
    Plain text mails only, please http://www.expita.com/nomime.html
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2006-02-27 10:44    [W:0.024 / U:153.180 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site