Messages in this thread Patch in this message | | | Date | Fri, 24 Feb 2006 16:07:05 +0000 (GMT) | From | Anton Altaparmakov <> | Subject | [PATCH 1/5] NTFS: Fix a potential overflow by casting (index + 1) to s64 |
| |
NTFS: Fix a potential overflow by casting (index + 1) to s64 before doing a left shift using PAGE_CACHE_SHIFT in fs/ntfs/file.c. Thanks to Andrew Morton pointing this out to.
Signed-off-by: Anton Altaparmakov <aia21@cantab.net>
---
Best regards,
Anton -- Anton Altaparmakov <aia21 at cam.ac.uk> (replace at with @) Unix Support, Computing Service, University of Cambridge, CB2 3QH, UK Linux NTFS maintainer / IRC: #ntfs on irc.freenode.net WWW: http://linux-ntfs.sf.net/ & http://www-stu.christs.cam.ac.uk/~aia21/
fs/ntfs/file.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
3c6af7fa787f21f8873a050568ed892312899eb5 diff --git a/fs/ntfs/file.c b/fs/ntfs/file.c index 7275338..c73c886 100644 --- a/fs/ntfs/file.c +++ b/fs/ntfs/file.c @@ -248,7 +248,7 @@ do_non_resident_extend: * enough to make ntfs_writepage() work. */ write_lock_irqsave(&ni->size_lock, flags); - ni->initialized_size = (index + 1) << PAGE_CACHE_SHIFT; + ni->initialized_size = (s64)(index + 1) << PAGE_CACHE_SHIFT; if (ni->initialized_size > new_init_size) ni->initialized_size = new_init_size; write_unlock_irqrestore(&ni->size_lock, flags); -- 1.2.3.g9821 - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |