Messages in this thread | | | Date | Fri, 24 Feb 2006 15:05:43 +1100 | From | 'David Gibson' <> | Subject | Re: [patch] fix ia64 hugetlb_free_pgd_range |
| |
On Thu, Feb 23, 2006 at 07:05:23PM -0800, Chen, Kenneth W wrote: > David Gibson wrote on Thursday, February 23, 2006 6:45 PM > > However... I suspect in fact that the transformations should be > > unconditional. > > No, that won't be correct.
But I don't see how not transforming them sometimes can be correct. Suppose 'floor' is only a little way below 'addr' - addr will be shifted down, but floor won't, so floor may now be above addr, which will cause weird results.
Afaict the *only* thing floor and ceiling are used for is bounds checking the address range we're examining. How can that ever be right if one address has been scaled down, but the other hasn't.
-- David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |