lkml.org 
[lkml]   [2006]   [Feb]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: [PATCH] flags parameter for linkat
On Thu, Feb 23, 2006 at 09:10:22AM -0500, Ulrich Drepper wrote:

> I'm currently at the POSIX meeting and one thing covered was the
> incompatibility of Linux's link() with the POSIX definition. The
> difference is the treatment of symbolic links in the destination
> name. Linux does not follow symlinks, POSIX requires it does.
>
> Even somebody thinks this is a good default behavior we cannot
> change this because it would break the ABI. But the fact remains
> that some application might want this behavior.
>
> We have one chance to help implementing this without breaking the
> behavior. For this we could use the new linkat interface which
> would need a new flags parameter. If the new parameter is
> AT_SYMLINK_FOLLOW the new behavior could be invoked.
>
> I do not want to introduce such a patch now. But we could add the
> parameter now, just don't use it. The patch below would do this.
> Can we get this late patch applied before the release more or less
> fixes the syscall API?

The number of arguments changes, so below patch would be needed for
32-bit MIPS.

Ralf

Signed-off-by: Ralf Baechle <ralf@linux-mips.org>

diff --git a/arch/mips/kernel/scall32-o32.S b/arch/mips/kernel/scall32-o32.S
index d83e033..2f2dc54 100644
--- a/arch/mips/kernel/scall32-o32.S
+++ b/arch/mips/kernel/scall32-o32.S
@@ -626,7 +626,7 @@ einval: li v0, -EINVAL
sys sys_fstatat64 4
sys sys_unlinkat 3
sys sys_renameat 4 /* 4295 */
- sys sys_linkat 4
+ sys sys_linkat 5
sys sys_symlinkat 3
sys sys_readlinkat 4
sys sys_fchmodat 3
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
\
 
 \ /
  Last update: 2006-02-23 21:30    [from the cache]
©2003-2011 Jasper Spaans