lkml.org 
[lkml]   [2006]   [Feb]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 2/3] map multiple blocks for mpage_readpages()
    On Mon, Feb 20, 2006 at 01:23:55PM -0800, Badari Pulavarty wrote:
    > [PATCH 2/3] map multiple blocks for mpage_readpages()
    >
    > This patch changes mpage_readpages() and get_block() to
    > get the disk mapping information for multiple blocks at the
    > same time.
    >
    > b_size represents the amount of disk mapping that needs to
    > mapped. On the successful get_block() b_size indicates the
    > amount of disk mapping thats actually mapped. Only the
    > filesystems who care to use this information and provide multiple
    > disk blocks at a time can choose to do so.
    >
    > No changes are needed for the filesystems who wants to ignore this.

    That's a nice way to handle this !

    Just one minor suggestion on the patches - instead of adding all those
    arguments to do_mpage_readpage, have you considered using
    an mio structure as we did in the mpage_writepages multiple blocks case ?

    Regards
    Suparna

    >
    > Thanks,
    > Badari
    >
    >



    --
    Suparna Bhattacharya (suparna@in.ibm.com)
    Linux Technology Center
    IBM Software Lab, India

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2006-02-23 04:31    [W:0.034 / U:0.172 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site