Messages in this thread | | | Date | Tue, 21 Feb 2006 12:49:51 +0000 (GMT) | From | Hugh Dickins <> | Subject | Re: [2.6 patch] unexport install_page |
| |
On Tue, 21 Feb 2006, Christoph Hellwig wrote: > On Mon, Feb 20, 2006 at 11:37:09PM +0100, Adrian Bunk wrote: > > No in-kernel module is using it, so there's no reason bloating the > > kernel with this EXPORT_SYMBOL. > > And no one should be using it, really.
Why's that?
> It's a helper for sys_remap_file_pages implementations,
Exactly (to support non-linear vmas and MAP_POPULATE).
> something that nothing but the generic filemap.c or shmem.c should do.
Why's that? It's rightly been recognized as a library function since 2.6.0-test3. I'd say it should remain exported for whatever filesystems might wish to use it (but no, I've no vested interest, the filesystem you'll suspect me of arguing for does not use it ;)
<akpm@osdl.org> [PATCH] export install_page() to modules
install_page() is a library function which we expect will be used by all drivers which implement vm_operations.populate(). Therefore it should be exported to kernel modules.
Petr Vandrovec has a project which involves sparse mappings of device memory which can use remap_file_pages(). It needs install_page().
Hugh - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |