Messages in this thread | | | From | Nigel Cunningham <> | Subject | Re: [ 02/10] [Suspend2] Module (de)registration. | Date | Thu, 2 Feb 2006 20:33:03 +1000 |
| |
Hi.
On Thursday 02 February 2006 19:54, Pavel Machek wrote: > On St 01-02-06 22:47:41, Nigel Cunningham wrote: > > Hi. > > > > On Wednesday 01 February 2006 22:37, Pekka Enberg wrote: > > > Hi, > > > > > > On 2/1/06, Nigel Cunningham <nigel@suspend2.net> wrote: > > > > +++ b/kernel/power/modules.c > > > > @@ -0,0 +1,87 @@ > > > > > > [snip] > > > > > > > + > > > > +struct list_head suspend_filters, suspend_writers, suspend_modules; > > > > +struct suspend_module_ops *active_writer = NULL; > > > > +static int num_filters = 0, num_ui = 0; > > > > +int num_writers = 0, num_modules = 0; > > > > > > Unneeded assignments, they're already guaranteed to be zeroed. > > > > Good point. Will fix. > > > > > > + list_add_tail(&module->module_list, &suspend_modules); > > > > + num_modules++; > > > > > > No locking, why? > > > > Not needed - the callers are _init routines only. > > And insmod?
Not right now. As I said in the intro, I want to have building as modules being an option again, but right now it's partially removed because of the symbol exporting issue.
Regards,
Nigel
-- See our web page for Howtos, FAQs, the Wiki and mailing list info. http://www.suspend2.net IRC: #suspend2 on Freenode [unhandled content-type:application/pgp-signature] | |