Messages in this thread | | | Date | Thu, 2 Feb 2006 20:33:57 -0500 | From | Dave Jones <> | Subject | Re: [patch -mm4] i386 cpu hotplug: don't access freed memory |
| |
On Thu, Feb 02, 2006 at 04:52:57PM -0800, Andrew Morton wrote: > Chuck Ebbert <76306.1226@compuserve.com> wrote: > > > > @@ -160,10 +162,17 @@ static void __cpuinit get_cpu_vendor(str > > c->x86_vendor = i; > > if (!early) > > this_cpu = cpu_devs[i]; > > - break; > > + return; > > } > > } > > } > > + if (!printed) { > > + printed++; > > + printk(KERN_ERR "CPU: Vendor unknown, using generic init.\n"); > > + printk(KERN_ERR "CPU: Your system may be unstable.\n"); > > + } > > + c->x86_vendor = X86_VENDOR_UNKNOWN; > > + this_cpu = &default_cpu; > > Well that's a worry. Under what circumstances (if any) will this final bit > of code get executed?
Some new x86 CPU vendor appears that we don't know about.
Dave - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |