lkml.org 
[lkml]   [2006]   [Feb]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch 1/5] MMC OMAP driver
Russell King wrote:
> Here's a revised patch. Pierre - could you look at the missing command
> types marked with /* ? */ in this patch please?
>
>

*snip*

> --- a/drivers/mmc/mmc.c
> +++ b/drivers/mmc/mmc.c
> @@ -211,7 +211,7 @@ int mmc_wait_for_app_cmd(struct mmc_host
>
> appcmd.opcode = MMC_APP_CMD;
> appcmd.arg = rca << 16;
> - appcmd.flags = MMC_RSP_R1;
> + appcmd.flags = MMC_RSP_R1 | MMC_CMD_AC; /* ? */
> appcmd.retries = 0;
> memset(appcmd.resp, 0, sizeof(appcmd.resp));
> appcmd.data = NULL;
>

Correct.

> @@ -358,7 +358,7 @@ static int mmc_select_card(struct mmc_ho
> struct mmc_command cmd;
> cmd.opcode = SD_APP_SET_BUS_WIDTH;
> cmd.arg = SD_BUS_WIDTH_4;
> - cmd.flags = MMC_RSP_R1;
> + cmd.flags = MMC_RSP_R1; /* ? */
>
> err = mmc_wait_for_app_cmd(host, card->rca, &cmd,
> CMD_RETRIES);
>

MMC_CMD_AC

> @@ -766,7 +766,7 @@ static int mmc_send_app_op_cond(struct m
>
> cmd.opcode = SD_APP_OP_COND;
> cmd.arg = ocr;
> - cmd.flags = MMC_RSP_R3;
> + cmd.flags = MMC_RSP_R3; /* ? */
>
> for (i = 100; i; i--) {
> err = mmc_wait_for_app_cmd(host, 0, &cmd, CMD_RETRIES);
>

MMC_CMD_BCR

> @@ -835,7 +835,7 @@ static void mmc_discover_cards(struct mm
>
> cmd.opcode = SD_SEND_RELATIVE_ADDR;
> cmd.arg = 0;
> - cmd.flags = MMC_RSP_R6;
> + cmd.flags = MMC_RSP_R6; /* ? */
>
> err = mmc_wait_for_cmd(host, &cmd, CMD_RETRIES);
> if (err != MMC_ERR_NONE)
>

MMC_CMD_BCR (feel free to update protocol.h since it's incorrect with
regard to this opcode)

> @@ -920,7 +920,7 @@ static void mmc_read_scrs(struct mmc_hos
>
> cmd.opcode = MMC_APP_CMD;
> cmd.arg = card->rca << 16;
> - cmd.flags = MMC_RSP_R1;
> + cmd.flags = MMC_RSP_R1 | MMC_CMD_AC; /* ? */
>
> err = mmc_wait_for_cmd(host, &cmd, 0);
> if ((err != MMC_ERR_NONE) || !(cmd.resp[0] & R1_APP_CMD)) {
>

Correct.

> @@ -932,7 +932,7 @@ static void mmc_read_scrs(struct mmc_hos
>
> cmd.opcode = SD_APP_SEND_SCR;
> cmd.arg = 0;
> - cmd.flags = MMC_RSP_R1;
> + cmd.flags = MMC_RSP_R1; /* ? */
>
> memset(&data, 0, sizeof(struct mmc_data));
>

MMC_CMD_ADTC

Rgds
Pierre

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-02-02 12:48    [W:0.064 / U:2.380 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site