Messages in this thread | | | Date | Sun, 19 Feb 2006 09:56:23 -0800 | From | Greg KH <> | Subject | Re: [PATCH, RFC] sysfs: relay channel buffers as sysfs attributes |
| |
Note that Pat isn't the sysfs maintainer anymore :)
On Sun, Feb 19, 2006 at 07:17:48PM +0200, Paul Mundt wrote: > Now with relayfs integrated and the relay_file_operations exported for > use by other file systems, I wonder what people think about adding in a > sysfs attribute for setting up channel buffers. > > The conventional relayfs doesn't make a lot of sense for the use cases > where there are multiple devices to stream data from, particularly if > they're already mapped out through the driver model. Rather than > duplicating device enumeration, simply adding this as an attribute seems > to work reasonably well. > > Tom did some work on the rchan_callbacks for more easily implementing > relay files in other file systems, and it would be nice to use this in a > non-debug context, without duplicating device enumeration in multiple > locations.
Looks good, I like it. This properly handles the module owner stuff, too, right?
And I agree with Christoph, with this change, you don't need a separate relayfs mount anymore.
thanks,
greg k-h - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |