lkml.org 
[lkml]   [2006]   [Feb]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [linux-pm] [PATCH 2/5] [pm] Add state field to pm_message_t (to hold actual state device is in)
On Sat, 18 Feb 2006, Pavel Machek wrote:

> Hi!
>
>
> > diff --git a/include/linux/pm.h b/include/linux/pm.h
> > index 5be87ba..a7324ea 100644
> > --- a/include/linux/pm.h
> > +++ b/include/linux/pm.h
> > @@ -140,6 +140,7 @@ struct device;
> >
> > typedef struct pm_message {
> > int event;
> > + u32 state;
> > } pm_message_t;
>
> We have had enough problems with u32s before... What about
> char *, and pass real state names?

Hear, hear! Exactly what I was going to say. Now that you want to add a
field describing an actual device state, make it meaningful.

BTW, you might want to look here:

http://lists.osdl.org/pipermail/linux-pm/2005-September/001422.html

for an example of an early implementation of just this idea. (I still
have the original patch file if you'd prefer to see it in plain text,
non-html format.)

Alan Stern

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-02-18 21:18    [W:0.104 / U:0.024 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site