Messages in this thread | | | From | Andi Kleen <> | Subject | Re: [PATCH: 001/012] Memory hotplug for new nodes v.2. (pgdat allocation) | Date | Fri, 17 Feb 2006 17:16:33 +0100 |
| |
On Friday 17 February 2006 16:39, Dave Hansen wrote:
> I'm a teensy bit concerned that this doesn't share enough code with the > boot-time initialization. For instance, the kthread_create() seems to > be a pretty darn generic piece. I'd feel a lot more at ease if this > patch did something with _existing_ code instead of just adding.
Agreed. Having significantly different code paths for hot add and for normal initialization isn't a good idea. It will just lead to long term code drift and problems.
So i would suggest to generalize the standard functions enough to make them callable from a hotplug layer.
-Andi - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |