lkml.org 
[lkml]   [2006]   [Feb]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Generic is_compat_task helper
On Thu, Feb 16, 2006 at 09:49:39PM -0800, Andrew Morton wrote:
> > +static inline int __is_compat_task(struct task_struct *t)
> > +{
> > + return (personality(t->personality) == PER_LINUX32);
> > +}
> > +
>
> What continues to bug me about this (in a high-level hand-wavy sort of way)
> is that this is an attribute of the mm_struct, not of the task_struct.
>

I'm not sure I agree, I can't find any real defined use for PER_LINUX32,
as opposed to PER_LINUX_32BIT, which is | ADDR_LIMIT_32BIT. That said,
I'm not opposed to moving parisc to use TIF_32BIT, in fact, I had this
in mind when I give the entrypoints a crapectomy.

Cheers,
Kyle
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-02-17 15:14    [W:0.655 / U:0.008 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site