Messages in this thread | | | Date | Wed, 15 Feb 2006 18:43:45 +0800 | From | Coywolf Qi Hunt <> | Subject | Re: [patch] make sysctl_overcommit_memory enumeration sensible |
| |
On Wed, Feb 15, 2006 at 12:32:38PM +0200, Avi Kivity wrote: > Coywolf Qi Hunt wrote: > > >On Wed, Feb 15, 2006 at 01:05:59AM -0800, Andrew Morton wrote: > > > > > >>Coywolf Qi Hunt <qiyong@fc-cn.com> wrote: > >> > >> > >>>I see system admins often confused when they sysctl > >>>vm.overcommit_memory. > >>>This patch makes overcommit_memory enumeration sensible. > >>> > >>>0 - no overcommit > >>>1 - always overcommit > >>>2 - heuristic overcommit (default) > >>> > >>>I don't feel this would break any userspace scripts. > >>> > >>> > >>eh? If any such scripts exist, they'll break. > >> > >>Confused. > >> > >> > > > >That's a corner case. Let'em break and fix. Otherwise, users will > >be confused. Even they get it right, after some weeks they'll have > >to re-read the doc. A logical user interface is important to human. > > > > > > If I have > > vm.overcommit_memory = 2 > > in my /etc/sysctl.conf, its meaning silently changes. I'll know about > it during the next oomkiller pass.
Indeed. See, the breakage doesn't hurt. -- Coywolf Qi Hunt - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |