lkml.org 
[lkml]   [2006]   [Feb]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [RFC][PATCH] UDF filesystem uid fix
    On 2/14/06, Phillip Susi <psusi@cfl.rr.com> wrote:
    > This seems to meet user expectations much better than the
    > previous behavior of changing ownership to root when unmounted.

    Reading mount man pages, the definition for uid/gid mount option for
    udf is "default user/group." I am pretty convinced that their original
    intent was to provide meaningful id for inodes that don't have one.
    Now what you're looking for sounds more like "mount whole filesystem
    as user/group" which is something different.

    The ownership changing to root thing is a bug caused by explicit
    memset() straight after we read the inode followed by flawed logic
    that forgets to set the uid. Your patch doesn't really fix that
    either, but it masks it. Unfortunately, now combining uid/git options
    with filesystem in which some inodes _have_ proper id yields to
    strange results. I don't see how it's reasonable for a filesystem to
    write invalid id on disk if I change the owner to myself even if I did
    use the mount options.

    So I don't think your patch is a proper fix for the ownership changing
    to root bug, nor do I think it is sufficient to provide the "mount fs
    as user" thing (which does sound useful). Now if you want to change
    uid/gid option semantics to "mount fs as user", please explain why you
    don't think my case matters, that is using uid/gid to provide id for
    inodes that don't have one but still expecting chown to work?

    Pekka
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2006-02-15 08:34    [W:0.022 / U:0.808 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site