lkml.org 
[lkml]   [2006]   [Feb]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Provide an interface for getting the current tick length
Andrew Morton writes:

> Paul Mackerras <paulus@samba.org> wrote:
>
> > Is that enough to be worth factoring out? Note that
> > update_wall_time_one_tick() needs both time_adjust_step and
> > delta_nsec, so to share more, we would have to have a function
> > returning two values and it would start to get ugly.
> >
>
> update_wall_time_one_tick() gets:
>
> long delta_nsec = new_function();
>
> and your new function becomes
>
> return (u64)new_function() << (SHIFT_SCALE - 10)) + time_adj;

and update_wall_time_one_tick misses out on this bit:

/* Reduce by this step the amount of time left */
time_adjust -= time_adjust_step;
That's why I said that update_wall_time_one_tick needs both
time_adjust_step and delta_nsec. If you have a nice way to return
both values, please let me know...

Paul.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-02-16 04:20    [from the cache]
©2003-2011 Jasper Spaans