lkml.org 
[lkml]   [2006]   [Feb]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] add asm-generic/mman.h


On Wed, 15 Feb 2006, Michael S. Tsirkin wrote:
>
> Other numbers look right, dont they?

Suggestion: for each macro name, do

grep "macroname" patch

and if you see anything that looks even half-way suspicious, check it.

Here's a pipeline from hell which shows that you broke at least
MADV_REMOVE (which has values 5-9 depending on architecture).

sed -n '/^[-+].*define[ ]*/
{ s/.*define[ ]*\([A-Za-z_0-9]*\).*/\1/ ; p}'
patch |
sort -u |
while read i
do
echo $i:
grep "^[-+].*$i" patch
done |
less -S

Rule #1: use tools instead of eyeballs whenever you possibly can. Humans
are bad at noticing changes like this.

Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2009-11-18 23:46    [W:0.112 / U:0.040 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site