lkml.org 
[lkml]   [2006]   [Feb]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [RFC][PATCH 0/4] PCI legacy I/O port free driver
    Andi Kleen wrote:
    > Kenji Kaneshige <kaneshige.kenji@jp.fujitsu.com> writes:
    >
    >
    >>I encountered a problem that some PCI devices don't work on my system
    >>which have huge number of PCI devices.
    >
    >
    > Is that a large IA64 system?
    >

    Yes. My IA64 system can have maximum 128 PCI slots, but
    currently many of devices on those slots don't work...

    > [...]
    >
    > The basic concept looks good to me, but I would suggest you use
    > the Linux bitmap functions (DECLARE_BITMAP(), set_bit, test_bit etc.)
    > instead of open coding all that.
    >
    > And for the e1000 change - instead of adding a big switch with
    > magic numbers that will likely bitrot it's better to use
    > the driver_data field in pci_device_id for such device specific flags.
    >

    I see.
    I will try to fix my patches based on your suggestion.

    Thanks,
    Kenji Kaneshige

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2006-02-15 04:21    [W:0.022 / U:61.436 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site