Messages in this thread | | | Date | Tue, 14 Feb 2006 22:14:27 +0100 | From | Takashi Iwai <> | Subject | Re: [PATCH] Add cast to __iomem pointer in scsi drivers |
| |
At Tue, 14 Feb 2006 21:05:38 +0000, Al Viro wrote: > > On Tue, Feb 14, 2006 at 09:59:05PM +0100, Takashi Iwai wrote: > > Yes, that'll be the best solution. But, in these drivers, the same > > struct fields are used for both inl() and writel() depending on the > > flag, so you cannot change the type. > > > > Hm, looks like I hit a dreadful case without a good solution. > > ioread*/iowrite*
Ah, that's it. Thanks.
So, the right fix is to rewrite struct ata_ioport to use iomem pointers and all accessses to ioread*/iowrite*() ? OK, it's a longer way to go :)
Takashi - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |