Messages in this thread | | | Date | Tue, 14 Feb 2006 20:45:22 +0100 | From | Christoph Hellwig <> | Subject | Re: [PATCH] pcmcia: use kthread_ API |
| |
On Tue, Feb 14, 2006 at 07:37:13PM +0000, Russell King wrote: > On Tue, Feb 14, 2006 at 06:50:16PM +0100, Christoph Hellwig wrote: > > Use the kthread_ API instead of opencoding lots of hairy code for kernel > > thread creation and teardown. > > > > Also use wake_up_process instead of an additional per-socket waitqueue. > > Nack. This breaks an error path - look at what happens when we fail to > register a socket - we set socket->thread to NULL and exit. That is > then picked up by the "socket thread for socket %p did not start" code > which you decided to remove.
Yes, you're right. Let's drop the patch for now. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |