lkml.org 
[lkml]   [2006]   [Feb]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: RFC: Compact Flash True IDE Mode Driver
On Tue, 14 Feb 2006, Alan Cox wrote:

> On Llu, 2006-02-13 at 11:35 +0100, Bartlomiej Zolnierkiewicz wrote:
> > > +static void cfide_outsl(unsigned long port, void *addr, u32 count)
> > > +{
> > > + panic("outsl unsupported");
> > > +}
> >
> > This will panic as soon as somebody tries to enable 32-bit I/O
> > using hdparm. Please add ide_hwif_t.no_io_32bit flag and teach
> > ide-disk.c:ide_disk_setup() about it (separate patch).
>
> Seems a lot of effort for little reward. Just make cfide_outsl generate
> word sized I/O instead. Ditto insl. Or even leave the panic. Only
> superusers can hack around with that value and they can equally crash
> the box a thousand other ways.

Well, there's a patch now and its pretty simple. Now we have one less way
superuser can kill things ;)

- k

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-02-14 18:00    [W:0.078 / U:0.552 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site