lkml.org 
[lkml]   [2006]   [Feb]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 08/13] hrtimer: remove data field

* Roman Zippel <zippel@linux-m68k.org> wrote:

> The nanosleep cleanup allows to remove the data field of hrtimer. The
> callback function can use container_of() to get it's own data. Since
> the hrtimer structure is usually embedded in other structures, the
> code also becomes a bit simpler.

i addressed this when you first raised this issue (back in the ktimers
flamewars), and generally the feeling of people i asked was that doing
the container_of() approach is less readable than an explicit 'data'
field. It also deviates from struct timer_list, which we wanted to stay
close to. Furthermore, for standalone hrtimers this creates the need to
generate a wrapper structure. So i dont really like this change - but no
strong feelings either way.

Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-02-13 14:59    [W:0.054 / U:0.296 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site