Messages in this thread | | | Subject | Re: [openib-general] Re: [git patch review 1/4] IPoIB: Don't start send-only joins while multicast thread is stopped | From | Roland Dreier <> | Date | Sun, 12 Feb 2006 08:37:48 -0800 |
| |
Michael> Basically, its as Andrew said: the lock around clear_bit Michael> is there to ensure that ipoib_mcast_send isnt running Michael> already when we stop the thread. Thats why test_bit has Michael> to be inside the lock, too.
Makes sense I guess. If I'm understanding correctly, the lock isn't really there to serialize the bit ops, but rather to make sure ipoib_mcast_send() won't do anything after we clear the bit.
Does that mean that there's no reason to take the lock around the set_bit()?
- R. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |