Messages in this thread | | | Date | Sun, 12 Feb 2006 18:28:47 +0300 | From | Sergey Vlasov <> | Subject | Re: [PATCH 1/2] [PCI] Secure Digital Host Controller id and regs |
| |
On Sat, 11 Feb 2006 01:15:23 +0100 Pierre Ossman wrote:
> Class code and register definitions for the Secure Digital Host Controller > standard. > > Signed-off-by: Pierre Ossman <drzeus@drzeus.cx> > --- > > include/linux/pci_ids.h | 1 + > include/linux/pci_regs.h | 3 +++ > 2 files changed, 4 insertions(+), 0 deletions(-) > > diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h > index 7a61ccd..5fa8ebe 100644 > --- a/include/linux/pci_ids.h > +++ b/include/linux/pci_ids.h > @@ -69,6 +69,7 @@ > #define PCI_CLASS_SYSTEM_TIMER 0x0802 > #define PCI_CLASS_SYSTEM_RTC 0x0803 > #define PCI_CLASS_SYSTEM_PCI_HOTPLUG 0x0804 > +#define PCI_CLASS_SYSTEM_SDHCI 0x0805 > #define PCI_CLASS_SYSTEM_OTHER 0x0880 > > #define PCI_BASE_CLASS_INPUT 0x09 > diff --git a/include/linux/pci_regs.h b/include/linux/pci_regs.h > index d27a78b..e6deda5 100644 > --- a/include/linux/pci_regs.h > +++ b/include/linux/pci_regs.h > @@ -108,6 +108,9 @@ > #define PCI_INTERRUPT_PIN 0x3d /* 8 bits */ > #define PCI_MIN_GNT 0x3e /* 8 bits */ > #define PCI_MAX_LAT 0x3f /* 8 bits */ > +#define PCI_SLOT_INFO 0x40 /* 8 bits */ > +#define PCI_SLOT_INFO_SLOTS(x) ((x >> 4) & 7) > +#define PCI_SLOT_INFO_FIRST_BAR_MASK 0x07
Does this really belong here? This register is specific to the SDHCI class, while all other definitions in pci_regs.h apply to all PCI devices.
drivers/mmc/sdhci.h seems to be a more logical place for SLOT_INFO definitions.
> > /* Header type 1 (PCI-to-PCI bridges) */ > #define PCI_PRIMARY_BUS 0x18 /* Primary bus number */ > [unhandled content-type:application/pgp-signature] | |