Messages in this thread | | | Date | Wed, 1 Feb 2006 17:50:01 -0700 | From | Shaun Jackman <> | Subject | Re: Liyitec PS/2 touch panel driver [PATCH] |
| |
On 1/31/06, Alexey Dobriyan <adobriyan@gmail.com> wrote: > > +static void liyitec_disconnect(struct serio *serio) > > +{ > > + struct liyitec *liyitec = serio_get_drvdata(serio); > > + > > + input_get_device(liyitec->dev); > > What do you want to do with return value?
As far as I know, input_get_device returns its argument. So, I don't want anything with the return value. input_get_device does increment the reference count of the underlying kobject though. Am I correct here?
> > +static void __exit liyitec_exit(void) > > +{ > > + printk(KERN_INFO "liyitec: %s\n", __func__); > > I suggest to drop this line.
Right. Will do.
Please cc me in your reply. Cheers, Shaun - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |