lkml.org 
[lkml]   [2006]   [Feb]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: Liyitec PS/2 touch panel driver [PATCH]
    On 1/31/06, Alexey Dobriyan <adobriyan@gmail.com> wrote:
    > > +static void liyitec_disconnect(struct serio *serio)
    > > +{
    > > + struct liyitec *liyitec = serio_get_drvdata(serio);
    > > +
    > > + input_get_device(liyitec->dev);
    >
    > What do you want to do with return value?

    As far as I know, input_get_device returns its argument. So, I don't
    want anything with the return value. input_get_device does increment
    the reference count of the underlying kobject though. Am I correct
    here?

    > > +static void __exit liyitec_exit(void)
    > > +{
    > > + printk(KERN_INFO "liyitec: %s\n", __func__);
    >
    > I suggest to drop this line.

    Right. Will do.

    Please cc me in your reply. Cheers,
    Shaun
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2006-02-02 01:52    [W:0.023 / U:150.396 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site