Messages in this thread | | | Date | Sat, 9 Dec 2006 00:49:39 -0800 | From | Andrew Morton <> | Subject | Re: [PATCH] x86 smp: export smp_num_siblings for oprofile |
| |
On Sat, 9 Dec 2006 00:34:24 -0800 Randy Dunlap <randy.dunlap@oracle.com> wrote:
> From: Randy Dunlap <randy.dunlap@oracle.com> > > oprofile uses smp_num_siblings without testing for CONFIG_X86_HT. > I looked at modifying oprofile, but this way is cleaner & simpler > and I didn't see a good reason not to just export it when CONFIG_SMP. > > WARNING: "smp_num_siblings" [arch/i386/oprofile/oprofile.ko] undefined! > > Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com> > --- > arch/i386/kernel/smpboot.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > --- linux-2.6.19-git13.orig/arch/i386/kernel/smpboot.c > +++ linux-2.6.19-git13/arch/i386/kernel/smpboot.c > @@ -69,7 +69,7 @@ static int __devinitdata smp_b_stepping; > > /* Number of siblings per CPU package */ > int smp_num_siblings = 1; > -#ifdef CONFIG_X86_HT > +#ifdef CONFIG_SMP > EXPORT_SYMBOL(smp_num_siblings); > #endif
smpboot.c isn't compiled if CONFIG_SMP=n, so I'll just remove the ifdef, thanks. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |