lkml.org 
[lkml]   [2006]   [Dec]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[patch 05/32] EBTABLES: Deal with the worst-case behaviour in loop checks.
    -stable review patch.  If anyone has any objections, please let us know.
    ------------------

    From: Al Viro <viro@zeniv.linux.org.uk>

    No need to revisit a chain we'd already finished with during
    the check for current hook. It's either instant loop (which
    we'd just detected) or a duplicate work.

    Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Chris Wright <chrisw@sous-sol.org>
    ---
    net/bridge/netfilter/ebtables.c | 4 +++-
    1 file changed, 3 insertions(+), 1 deletion(-)

    --- linux-2.6.19.orig/net/bridge/netfilter/ebtables.c
    +++ linux-2.6.19/net/bridge/netfilter/ebtables.c
    @@ -717,7 +717,9 @@ static int check_chainloops(struct ebt_e
    BUGPRINT("loop\n");
    return -1;
    }
    - /* this can't be 0, so the above test is correct */
    + if (cl_s[i].hookmask & (1 << hooknr))
    + goto letscontinue;
    + /* this can't be 0, so the loop test is correct */
    cl_s[i].cs.n = pos + 1;
    pos = 0;
    cl_s[i].cs.e = ((void *)e + e->next_offset);
    --
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2006-12-09 01:11    [W:0.021 / U:0.844 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site