lkml.org 
[lkml]   [2006]   [Dec]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] netpoll: make arp replies through netpoll use mac address of sender
On Fri, Dec 08, 2006 at 12:07:27AM -0800, David Miller wrote:
> From: Neil Horman <nhorman@tuxdriver.com>
> Date: Thu, 7 Dec 2006 14:45:53 -0500
>
> > Back in 2.4 arp requests that were recevied by netpoll were processed in
> > netconsole_receive_skb, where they were responded to using the src mac of the
> > request sender. In the 2.6 kernel arp_reply is responsible for this function,
> > but instead of using the src mac address of the incomming request, the stored
> > mac address that was registered for the netconsole application is used. While
> > this is usually ok, it can lead to failures in netpoll in some situations
> > (specifically situations where a network may have two gateways, as arp requests
> > from one may be responded to using the mac address of the other). This patch
> > reverts the behavior to what we had in 2.4, in which all arp requests are sent
> > back using the src address of the request sender.
> >
> > Signed-off-by: Neil Horman <nhorman@tuxdriver.com>
>
> Applied, and I'll push this to -stable, thanks Neil.
>
> But please submit networking patches next time to
> netdev@vger.kernel.org, most of the networking developers did not see
> this patch because you sent it to the user help list (linux-net)
> instead of the developer list (netdev).
>
My bad, wasn't thinking. Thanks guys!
Neil

> Thanks again.

--
/***************************************************
*Neil Horman
*Software Engineer
*gpg keyid: 1024D / 0x92A74FA1 - http://pgp.mit.edu
***************************************************/
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-12-08 15:17    [W:0.036 / U:10.100 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site