lkml.org 
[lkml]   [2006]   [Dec]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
Subject[PATCH] kbuild : Make Fusion MPT selectable from "Device drivers" menu

Rewrite the Fusion MPT Kconfig file so that all of MPT functionality
is entirely selectable from "Device drivers."

Signed-off-by: Robert P. J. Day <rpjday@mindspring.com>

---

The original Kconfig file seems to have an odd structure, as you can
see from the first part of the file:

========================================================
menu "Fusion MPT device support"

config FUSION
bool
default n

config FUSION_SPI
tristate "Fusion MPT ScsiHost drivers for SPI"
depends on PCI && SCSI
select FUSION
select SCSI_SPI_ATTRS
...
========================================================

note how the majority of entries in that file don't directly
*depend* on FUSION. instead, they depend on *external* config
variables, and *select* FUSION, and this is not the only place i've
noticed that kind of dependency wording.

is that a regular feature? having that structure certainly makes it
slightly more difficult to rewrite the menu entries, and it's not
clear there's any obvious advantage to doing it that way.


diff --git a/drivers/message/fusion/Kconfig b/drivers/message/fusion/Kconfig
index ea31d84..b2da14d 100644
--- a/drivers/message/fusion/Kconfig
+++ b/drivers/message/fusion/Kconfig
@@ -1,14 +1,12 @@
-
-menu "Fusion MPT device support"
-
-config FUSION
- bool
+menuconfig FUSION
+ bool "Fusion MPT device support"
default n

+if FUSION
+
config FUSION_SPI
tristate "Fusion MPT ScsiHost drivers for SPI"
depends on PCI && SCSI
- select FUSION
select SCSI_SPI_ATTRS
---help---
SCSI HOST support for a parallel SCSI host adapters.
@@ -23,7 +21,6 @@ config FUSION_SPI
config FUSION_FC
tristate "Fusion MPT ScsiHost drivers for FC"
depends on PCI && SCSI
- select FUSION
select SCSI_FC_ATTRS
---help---
SCSI HOST support for a Fiber Channel host adapters.
@@ -40,7 +37,6 @@ config FUSION_FC
config FUSION_SAS
tristate "Fusion MPT ScsiHost drivers for SAS"
depends on PCI && SCSI
- select FUSION
select SCSI_SAS_ATTRS
---help---
SCSI HOST support for a SAS host adapters.
@@ -100,4 +96,4 @@ config FUSION_LAN

If unsure whether you really want or need this, say N.

-endmenu
+endif
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
\
 
 \ /
  Last update: 2006-12-07 13:09    [W:0.033 / U:7.372 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site