Messages in this thread Patch in this message | | | From | NeilBrown <> | Date | Fri, 8 Dec 2006 12:13:31 +1100 | Subject | [PATCH 002 of 18] knfsd: svcrpc: fix gss krb5i memory leak |
| |
From: J.Bruce Fields <bfields@fieldses.org>
The memory leak here is embarassingly obvious.
This fixes a problem that causes the kernel to leak a small amount of memory every time it receives a integrity-protected request.
Thanks to Aimé Le Rouzic for the bug report.
Signed-off-by: J. Bruce Fields <bfields@citi.umich.edu> Signed-off-by: Neil Brown <neilb@suse.de>
### Diffstat output ./net/sunrpc/auth_gss/svcauth_gss.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-)
diff .prev/net/sunrpc/auth_gss/svcauth_gss.c ./net/sunrpc/auth_gss/svcauth_gss.c --- .prev/net/sunrpc/auth_gss/svcauth_gss.c 2006-12-08 12:07:28.000000000 +1100 +++ ./net/sunrpc/auth_gss/svcauth_gss.c 2006-12-08 12:08:05.000000000 +1100 @@ -818,19 +818,19 @@ unwrap_integ_data(struct xdr_buf *buf, u integ_len = svc_getnl(&buf->head[0]); if (integ_len & 3) - goto out; + return stat; if (integ_len > buf->len) - goto out; + return stat; if (xdr_buf_subsegment(buf, &integ_buf, 0, integ_len)) BUG(); /* copy out mic... */ if (read_u32_from_xdr_buf(buf, integ_len, &mic.len)) BUG(); if (mic.len > RPC_MAX_AUTH_SIZE) - goto out; + return stat; mic.data = kmalloc(mic.len, GFP_KERNEL); if (!mic.data) - goto out; + return stat; if (read_bytes_from_xdr_buf(buf, integ_len + 4, mic.data, mic.len)) goto out; maj_stat = gss_verify_mic(ctx, &integ_buf, &mic); @@ -840,6 +840,7 @@ unwrap_integ_data(struct xdr_buf *buf, u goto out; stat = 0; out: + kfree(mic.data); return stat; } - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |