[lkml]   [2006]   [Dec]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
Patch in this message
SubjectRe: ... and more...
Al Viro <> wrote:

> diff --git a/drivers/i2c/chips/m41t00.c b/drivers/i2c/chips/m41t00.c

This could be done differently. m41t00_set() is only called on that global
variable, so why pass its address in as an argument?

The old code is also wrong: m41t00_set() was being passed a pointer to an
unsigned long, but then was casting it to a pointer to an int before
dereferencing it. This works on a 32-bit platform, but it's just asking for
trouble on a 64-bit big-endian platform. However, the driver can only be
configured when CONFIG_PPC32=y, so it will have gone unnoticed.

Fix m41t00_set() and its usage with workqueues

From: David Howells <>

Fix m41t00_set() and its usage with workqueues. It doesn't really need an
argument since it always affects the same global variable.

Signed-Off-By: David Howells <>

drivers/i2c/chips/m41t00.c | 18 ++++++------------
1 files changed, 6 insertions(+), 12 deletions(-)

diff --git a/drivers/i2c/chips/m41t00.c b/drivers/i2c/chips/m41t00.c
index 420377c..98978ab 100644
--- a/drivers/i2c/chips/m41t00.c
+++ b/drivers/i2c/chips/m41t00.c
@@ -165,11 +165,13 @@ read_err:

+static ulong new_time;
static void
-m41t00_set(void *arg)
+m41t00_set(struct work_struct *unused)
struct rtc_time tm;
- int nowtime = *(int *)arg;
+ int nowtime = new_time;
s32 sec, min, hour, day, mon, year;
u8 wbuf[9], *buf = &wbuf[1], msgbuf[1] = { 0 };
struct i2c_msg msgs[] = {
@@ -214,16 +216,8 @@ m41t00_set(void *arg)
dev_err(&save_client->dev, "m41t00_set: Write error\n");

-static ulong new_time;
-/* well, isn't this API just _lovely_? */
-static void
-m41t00_barf(struct work_struct *unusable)
- m41t00_set(&new_time);
static struct workqueue_struct *m41t00_wq;
-static DECLARE_WORK(m41t00_work, m41t00_barf);
+static DECLARE_WORK(m41t00_work, m41t00_set);

m41t00_set_rtc_time(ulong nowtime)
@@ -233,7 +227,7 @@ m41t00_set_rtc_time(ulong nowtime)
if (in_interrupt())
queue_work(m41t00_wq, &m41t00_work);
- m41t00_set(&new_time);
+ m41t00_set(NULL);

return 0;
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at
 \ /
  Last update: 2006-12-07 14:11    [W:0.037 / U:3.924 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site